Do not panic when parsing '.' in URL host: #166 #170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a url such as file://./foo the parser should not panic.
|
Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion. src/host.rs, line 62 [r1] (raw file): Comments from the review on Reviewable.io |
|
Thanks for the PR! It turns out the underlying cause of the issue was a bit more subtle, so I’ll close this in favor of #171. |
|
Specifically, a domain made of just a dot is turned into the empty string by IDNA code. For the spec, see also whatwg/url#79 |
|
Thanks! Great comment on the spec too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #166. The parser should not panic when parsing URLs such as
file://./foo.Really this was just an excuse to dig into
rust-urland learn more about it, so tips, comments, and critiques are welcomed!