Skip to content

Bring fuzzer up to date #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2017
Merged

Bring fuzzer up to date #342

merged 2 commits into from
May 18, 2017

Conversation

Hoverbear
Copy link

@Hoverbear Hoverbear commented May 17, 2017

Went to go run some fuzzing today and hit some speed bumps. This brings it up to date and inline with the latest versions.


This change is Reviewable

@Hoverbear Hoverbear added the bug label May 17, 2017
@Hoverbear Hoverbear requested a review from Manishearth May 17, 2017 11:33
@Manishearth
Copy link
Member

Could you also update the fuzz script to use the new macro format?

@Hoverbear
Copy link
Author

One of these? https://github.com/rust-fuzz/cargo-fuzz/search?utf8=%E2%9C%93&q=macro_rules&type= I can't find any other associated macros.

@Manishearth
Copy link
Member

Try creating a new script (cargo fuzz add foo.rs) and copy its contents.

@Hoverbear
Copy link
Author

@Manishearth Thanks for the pointer. :) Updated.

@Manishearth
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 1b97ceb has been approved by Manishearth

@bors-servo
Copy link
Contributor

⌛ Testing commit 1b97ceb with merge 8b8d143...

bors-servo pushed a commit that referenced this pull request May 18, 2017
Bring fuzzer up to date

Went to go run some fuzzing today and hit some speed bumps. This brings it up to date and inline with the latest versions.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/342)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: Manishearth
Pushing 8b8d143 to master...

@bors-servo bors-servo merged commit 1b97ceb into master May 18, 2017
@Hoverbear Hoverbear deleted the bugfix/fuzzing branch May 18, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants