Skip to content

Exclude unneeded files from the crate package. #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Exclude unneeded files from the crate package. #435

wants to merge 1 commit into from

Conversation

RazrFalcon
Copy link

@RazrFalcon RazrFalcon commented Feb 18, 2018

This decreases *.crate file size from 282KiB to 90KiB.


This change is Reviewable

@SimonSapin
Copy link
Member

I personally don’t care much, but some people have files bugs on some other crates when cargo test doesn’t work in the result of extracting a .crate file from crates.io. I suppose it’d be nice to have a community-wide convention of what’s appropriate to do/expect around this.

@nox, do you have an opinion?

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #517) made this pull request unmergeable. Please resolve the merge conflicts.

@RazrFalcon RazrFalcon closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants