-
Notifications
You must be signed in to change notification settings - Fork 35
Use of int8 for call_genotype results in integer overflow with complex variants #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 - this is definitely an issue. Setting based on max_alt_alleles is good, and I think that seals the deal on mapping any alleles we can't represent to missing data. |
+1 BTW I just opened #643, which is tangentially related. @timothymillar I wonder if you see a few very long alleles in your data? |
I'm currently working with alleles with lengths 120bp. These are fixed sized "chunks" across the genome (targeted sequencing) so fixed length strings are suitable. But I think we'll use more variable allele lengths in future as these chunks need some tuning. |
Good to know - thanks. |
I'm working with some microhaplotype variant calls in which the number of the alleles can be >300 (likely due to poor quality calls at some loci). It would be ideal if the
call_genotype
dtype was configurable and/or automatically set based on themax_alt_alleles
parameter. Similar discussion in #584.The text was updated successfully, but these errors were encountered: