Skip to content

Add asv benchmark for compression ratio of some example VCFs #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomwhite opened this issue Oct 18, 2022 · 6 comments
Closed

Add asv benchmark for compression ratio of some example VCFs #938

tomwhite opened this issue Oct 18, 2022 · 6 comments

Comments

@tomwhite
Copy link
Collaborator

Suggested by @benjeffery in https://github.com/pystatgen/sgkit/pull/937#pullrequestreview-1145718679

@tomwhite
Copy link
Collaborator Author

@hammer
Copy link
Contributor

hammer commented Oct 26, 2022

I was also pointed to airspeed-velocity/asv#1219 as an important issue where the future of ASV is being discussed.

@hammer
Copy link
Contributor

hammer commented Oct 26, 2022

It definitely sounds like pytest-benchmark is the simpler starting point.

@hammer
Copy link
Contributor

hammer commented Oct 27, 2022

Nvidia made a tool to transform pytest-benchmark output to a format expected by asv for visualization: https://github.com/rapidsai/asvdb

@tomwhite
Copy link
Collaborator Author

tomwhite commented Dec 5, 2022

It seems that pytest-benchmark doesn't support custom metrics that aren't timing-related, i.e. compression ratio in our case here.

coiled/benchmarks#186 is worth a read.

@tomwhite
Copy link
Collaborator Author

tomwhite commented Jan 4, 2023

Fixed in #978

@tomwhite tomwhite closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants