Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses data from #925 in a test that asserts that the Zarr size is less than 75% of the gzipped VCF. It could be made into a benchmark (
asv
or otherwise, see #938), but for the moment it was simplest to write it as a regular unit test.When writing this I found a bug/limitation (f7d44a8) where the Zarr chunk size in the samples dimension is set to 1000 (the default), and not limited to the number of samples. This would be potentially wasteful and slow for VCFs with just a few samples. @benjeffery I wonder if this change helps speed up your TB VCF import?