Skip to content

Rename dimensions 'sample_x' and 'sample_y' in PC relate #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021

Conversation

tomwhite
Copy link
Collaborator

...to 'samples_0' and 'samples_1' for consistency with popgen.

Fixes #284

…0' and 'samples_1' for consistency with popgen.
@tomwhite tomwhite requested a review from ravwojdyla May 18, 2021 10:16
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #574 (38e2683) into main (e286e75) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #574   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           35        35           
  Lines         2749      2749           
=========================================
  Hits          2749      2749           
Impacted Files Coverage Δ
sgkit/stats/pc_relate.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e286e75...38e2683. Read the comment docs.

@tomwhite tomwhite added the auto-merge Auto merge label for mergify test flight label May 18, 2021
@mergify mergify bot merged commit fb10b28 into sgkit-dev:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Auto merge label for mergify test flight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document/unify naming convention for repeated dimensions
3 participants