Skip to content

Reject (instead of ignore) the OTA option, now it's no longer supported #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
henrypijames opened this issue Feb 18, 2017 · 2 comments
Closed

Comments

@henrypijames
Copy link

henrypijames commented Feb 18, 2017

Shadowsocks is moving away from OTA towards AEAD, and that's fine. But as a casual observer of the protocol development, I only knew about the addition of AEAD, but didn't realize that OTA has been removed as a consequence. After installing the latest version of shadowsocks-libev, I spend a considerable amount of time debugging why the auth: true line in my config.json no longer has any effect, until I finally did a ss-server --help and saw that -A no longer exists.

In order to make clear to older users of OTA that this is no longer supported, I propose that instead of silently ignoring the now obsolete OTA option, shadowsocks-libev immediately terminate if the OTA option is activated (either per command-line, config file, or by any other means). and output an error message stating clearly that OTA is no longer supported.

@henrypijames henrypijames changed the title Reject the OTA option, now it's no longer support Reject (instead of ignore) the OTA option, now it's no longer support Feb 18, 2017
@henrypijames henrypijames changed the title Reject (instead of ignore) the OTA option, now it's no longer support Reject (instead of ignore) the OTA option, now it's no longer supported Feb 18, 2017
madeye added a commit that referenced this issue Feb 18, 2017
@madeye
Copy link
Contributor

madeye commented Feb 18, 2017

Try c46f10b.

@henrypijames
Copy link
Author

henrypijames commented Feb 18, 2017

Reading the code, it seems that you only get the error message with auth in config file, but not with the -A command line parameter - at least not the specific message about OTA being deprecated.

madeye added a commit that referenced this issue Feb 19, 2017
@madeye madeye closed this as completed Feb 20, 2017
madeye added a commit that referenced this issue Feb 20, 2017
* Add Ping-Pong bloom filter

* Refine bloom filter insertion

* Reduce the error rate to 0.00001

* Avoid alignment issue in murmurhash2

* Fix a memory leak

* Fix build on non-GPU targets

* Detect get_current_dir_name in configure

* Update README.md

* Remove redudant bfree()

* Reduce the memory usage for local client

* Fix #1275

* Refine #1275

* Use IP when bypassing SNI domains

* Also apply replay detector on UDP traffic

* Update deb build script

Now build script is able to auto detect system and choose libraries
necessary to build.

Also update the README accordingly.

* Update build script to enable jessie/stretch etc

Also include a few cleanup that simplified pkg installation from
backports repository.
madeye added a commit that referenced this issue Mar 16, 2017
* Add Ping-Pong bloom filter

* Refine bloom filter insertion

* Reduce the error rate to 0.00001

* Avoid alignment issue in murmurhash2

* Fix a memory leak

* Fix build on non-GPU targets

* Detect get_current_dir_name in configure

* Update README.md

* Remove redudant bfree()

* Reduce the memory usage for local client

* Fix #1275

* Refine #1275

* Use IP when bypassing SNI domains

* Also apply replay detector on UDP traffic

* Update deb build script

Now build script is able to auto detect system and choose libraries
necessary to build.

Also update the README accordingly.

* Update build script to enable jessie/stretch etc

Also include a few cleanup that simplified pkg installation from
backports repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants