Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Disambiguate modification time vs timestamp #1704

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

vp-elitnet
Copy link
Contributor

Description of --changed-within has the following statement.

Files with modification times greater than the argument will be returned.

At least for me the natural interpretation of "modification time" is relative, e.g. 2 weeks ago, 24 hours ago, etc. Using this interpretation the statement above is opposite of the actual behaviour: modification time greater than (i.e. more than) 24 hour would match files older than the argument, not newer.

I think the statement intended to say "modification timestamps greater than", which would make it unambiguous, i.e. prevent the incorrect interpretation. Fixed descriptions of both --changed-within and --changed-before accordingly.

@tavianator tavianator merged commit edafedb into sharkdp:master Apr 2, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants