Skip to content

Commit 87d5fb2

Browse files
Kartik_BurmeeAtin Mukherjee
Kartik_Burmee
authored and
Atin Mukherjee
committed
glusterd: dead code coverity fix
function: glusterd_volume_rebalance_use_rsp_dict problem: Execution cannot reach this statement: "goto out;" fix: removed the condition 'if(!ctx_dict)' and the corresponding action 'goto out;' because it will never be executed. reason: if the execution reaches this condition, then the value of '!ctx_dict' will always be false otherwise the execution will reach the 'out' label, skipping the execution of this conditional statement. html link of issue: https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-11-10-0f524f07/html/1/99glusterd-utils.c.html#error Change-Id: I7ab6b2386bb01c54edd872f9f83bb8d2a4cd499f BUG: 789278 Signed-off-by: Kartik_Burmee <[email protected]>
1 parent 27e5fbf commit 87d5fb2

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

xlators/mgmt/glusterd/src/glusterd-utils.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10498,8 +10498,6 @@ glusterd_volume_rebalance_use_rsp_dict (dict_t *aggr, dict_t *rsp_dict)
1049810498
goto out;
1049910499
}
1050010500

10501-
if (!ctx_dict)
10502-
goto out;
1050310501

1050410502
ret = dict_get_str (ctx_dict, "volname", &volname);
1050510503
if (ret) {

0 commit comments

Comments
 (0)