fix(ui): fix TerminalDialog layout #4745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizhf42
force-pushed
the
fix/terminal-dialog
branch
from
1890150 to
c1adb3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the layout of the
TerminalDialoglogin form, giving more consistency to the whole website design. The buttons were rearranged to be the same as the other dialogs. Additionally, the form is now auto-submitted when theEnterkey is pressed, making it more accessible and improving the UX. Tests for these changes were also added, along with a small refactoring in the old tests.The component and the tests still need a bigger refactor, which will be done in a subsequent branch/PR.