Skip to content

Add explicit @JsonProperty mapping to every @JsonCreator factory method #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ To do this you will need to add this configuration to your `pom.xml`:
<dependency>
<groupId>com.shift4</groupId>
<artifactId>shift4-java</artifactId>
<version>2.7.0</version>
<version>2.8.0</version>
</dependency>
```

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
}

group = "com.shift4"
version = "2.7.0"
version = "2.8.0"
archivesBaseName = "shift4-java"

repositories {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/AuthenticationFlow.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public enum AuthenticationFlow {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static AuthenticationFlow fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/BlacklistRuleType.java
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public enum BlacklistRuleType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static BlacklistRuleType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/CardBrand.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public enum CardBrand {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static CardBrand fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/CardType.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public enum CardType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static CardType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/ChargeFlowActionType.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public enum ChargeFlowActionType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static ChargeFlowActionType fromValue(String value) {
if (value == null) {
return null;
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/com/shift4/enums/ChargeStatus.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.shift4.enums;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.annotation.JsonValue;

public enum ChargeStatus {
Expand All @@ -21,7 +22,7 @@ public enum ChargeStatus {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static ChargeStatus fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/DisputeReason.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public enum DisputeReason {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static DisputeReason fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/DisputeStatus.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public enum DisputeStatus {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static DisputeStatus fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/ErrorCode.java
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public enum ErrorCode {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static ErrorCode fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/ErrorType.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public enum ErrorType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static ErrorType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/EventType.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public enum EventType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static EventType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/FileUploadPurpose.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public enum FileUploadPurpose {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static FileUploadPurpose fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/FileUploadType.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public enum FileUploadType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static FileUploadType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/FraudStatus.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public enum FraudStatus {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static FraudStatus fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/Interval.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public enum Interval {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static Interval fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/LiabilityShift.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public enum LiabilityShift {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static LiabilityShift fromValue(String value) {
if (value == null) {
return null;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public enum PaymentMethodFlowActionType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static PaymentMethodFlowActionType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/PaymentMethodStatus.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public enum PaymentMethodStatus {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static PaymentMethodStatus fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/PaymentMethodType.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public enum PaymentMethodType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static PaymentMethodType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/PayoutTransactionType.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public enum PayoutTransactionType {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static PayoutTransactionType fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/RefundReason.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public enum RefundReason {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static RefundReason fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/RefundStatus.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public enum RefundStatus {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static RefundStatus fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/enums/SubscriptionStatus.java
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public enum SubscriptionStatus {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static SubscriptionStatus fromValue(String value) {
if (value == null) {
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/shift4/response/AvsCheckResult.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public enum AvsCheckResult {
this.value = value;
}

@JsonCreator
@JsonCreator(mode = JsonCreator.Mode.DELEGATING)
public static AvsCheckResult fromValue(String value) {
if (value == null) {
return null;
Expand Down