Handle compress vm image files and added documentation #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2019 09:02
- The filename used for the vm images has changed, and the files are now compressed with gzip so after downloading they need to be uncompress. Also the filename used to save the qcow2 files is programatically determined. - If a newer vesion of tmate is installed script shoudl not exit with error. - Enhanced documentation
adduarte
requested review from
tomassedovic,
iamemilio,
mandre and
pierreprinetti
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files used for the vm images are now gzipped, thus the script needs to uncompressed the files before creating the glance image.
Added some more details on the documentation about getting the local machine ready for installation.