Fix build against clang 16 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch upgrades the `bindgen` dependency to version 0.64 which includes a fix for an upstream issue broken builds when building w/ clang 16 or newer [0]. The use of a wildcard `*` was removed in bindgen 0.62 [1], code has been updated to use the regex approach instead to continue working. [0]: rust-lang/rust-bindgen#2316 [1]: rust-lang/rust-bindgen#2373
|
If you can include this before you release the |
|
I should've read this before I published 😂 that's okay there can be a 1.0.2 |
|
sys 1.0.2 is published with both fixes |
|
Thanks ❤️ |
mqudsi
added a commit
to mqudsi/Av1an
that referenced
this pull request
Feb 11, 2023
The recent updates to the ffmpeg dependencies broke the `ffmpeg_static` feature to request linking against a static build of ffmpeg due to an upstream change in how the ffmpeg repo tagged releases [0]. The v1.0.2 of the transitive ffmpeg-sys-the-third dependency includes the needed fix to get static ffmpeg builds to work again (at all) as well as to get static builds working on clang 16 [1]. [0]: shssoichiro/ffmpeg-the-third#3 [1]: shssoichiro/ffmpeg-the-third#5
mergify bot
pushed a commit
to rust-av/Av1an
that referenced
this pull request
Feb 11, 2023
The recent updates to the ffmpeg dependencies broke the `ffmpeg_static` feature to request linking against a static build of ffmpeg due to an upstream change in how the ffmpeg repo tagged releases [0]. The v1.0.2 of the transitive ffmpeg-sys-the-third dependency includes the needed fix to get static ffmpeg builds to work again (at all) as well as to get static builds working on clang 16 [1]. [0]: shssoichiro/ffmpeg-the-third#3 [1]: shssoichiro/ffmpeg-the-third#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch upgrades the
bindgendependency to version 0.64 which includes a fix for an upstream issue broken builds when building w/ clang 16 or newer [0].The use of a wildcard
*was removed in bindgen 0.62 [1], code has been updated to use the regex approach instead to continue working.[0]: rust-lang/rust-bindgen#2316
[1]: rust-lang/rust-bindgen#2373