Move @typings/jest to devDependencies #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since jest functions are global, their typing tends to conflict with other global properties in global space. This commit moves jest typings to devDependencies, where they won't be included for projects that require jest-fetch-mock. This is very similar to a protractor issue, reference here- angular/protractor#3792 angular/protractor#3795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since jest functions are global, their typing tends to conflict with other global properties in
global space. This commit moves jest typings to devDependencies, where they won't be
included for projects that require jest-fetch-mock.
This is very similar to a protractor issue, reference here-
angular/protractor#3792
angular/protractor#3795