[Vite] Instruct users to create plugins with Vite instead of CRA #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnaarya
changed the title
Pearce-Ropion
previously approved these changes
Feb 19, 2025
README.md
Outdated
|
|
||
| NOTE: Facebook's [create-react-app](https://github.com/facebook/create-react-app) breaks with React 19 (see https://github.com/facebook/create-react-app/issues/17004). | ||
|
|
||
| You should use [vite](https://github.com/vitejs/vite) instead to create custom plugins. |
There was a problem hiding this comment.
Edit the wording to not use instead. Instead of treating the change as a "we used to recommend this old way but you should use this new way instead", just make it so that the new way is "the only way we recommend".
Pearce-Ropion
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SIG-41705
What is the purpose of this PR?
Facebook's create-react-app is deprecated.
We should instruct users to setup with vite instead to create custom plugins.