Skip to content

support create dispatch event #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 23, 2025

Conversation

rscohn2
Copy link
Contributor

@rscohn2 rscohn2 commented Feb 2, 2025

@sigmavirus24
Copy link
Owner

This makes total sense to add thanks for the PR!

@rscohn2
Copy link
Contributor Author

rscohn2 commented Feb 19, 2025

Could you kick off another run? Maybe they fixed the issue with python 3.7 not being available.

@sigmavirus24
Copy link
Owner

Unlikely. 3.7 is also deprecated as is I believe 3.8. If you would be willing to update the list of Python versions being tested, that should help

@rscohn2
Copy link
Contributor Author

rscohn2 commented Feb 22, 2025

If you would be willing to update the list of Python versions being tested, that should help

Done.

@rscohn2 rscohn2 force-pushed the rscohn1/dispatch-event branch from f8f5a70 to a565a26 Compare February 22, 2025 14:29
@rscohn2 rscohn2 requested a review from sigmavirus24 February 22, 2025 14:32
@rscohn2
Copy link
Contributor Author

rscohn2 commented Feb 22, 2025

Is this the problem?

docs/source/release-notes/1.0.0.rst:103: D001 Line too long
docs/source/release-notes/1.0.0.rst:105: D001 Line too long
docs/source/release-notes/1.0.0.rst:126: D001 Line too long
docs/source/release-notes/1.0.0.rst:127: D001 Line too long
docs/source/release-notes/1.0.0.rst:128: D001 Line too long
docs/source/release-notes/1.0.0.rst:1[D001 Line too long
docs/source/release-notes/1.0.0.rst:161: D001 Line too long
docs/source/release-notes/1.0.0.rst:192: D001 Line too long

It looks like this should have handled it:

ignore-path-errors = docs/source/release-notes/1.0.0.rst;D001

I can investigate why it doesn't seem to work later.

@sigmavirus24
Copy link
Owner

Thanks! I'm guessing doc8 changed something in how it handles something and it isn't seeing the configuration anymore

@sigmavirus24
Copy link
Owner

I had tried tracking this down before but I wasn't able to sort it out honestly and don't have oodles of free time.

@sigmavirus24
Copy link
Owner

Just looked at the issue tracker and found PyCQA/doc8#168 so maybe adding a !=1.1.2 to tox for doc8 fixes this?

@rscohn2 rscohn2 force-pushed the rscohn1/dispatch-event branch from d7f6bc5 to 7502e75 Compare February 22, 2025 17:52
@rscohn2
Copy link
Contributor Author

rscohn2 commented Feb 22, 2025

Just looked at the issue tracker and found PyCQA/doc8#168 so maybe adding a !=1.1.2 to tox for doc8 fixes this?

That fixed it my local run. I pushed the change.

Copy link
Owner

@sigmavirus24 sigmavirus24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@sigmavirus24 sigmavirus24 enabled auto-merge (squash) February 22, 2025 20:47
@sigmavirus24 sigmavirus24 merged commit 242a5eb into sigmavirus24:main Feb 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants