Change default EngineState to online #7417
Merged
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barnabasbusa can you test if this PR fixes your issue? |
michaelsproul
approved these changes
May 8, 2025
michaelsproul
added
the
waiting-on-author
|
@pawanjay176 Looks like some tests need updating |
|
This PR fixed the bug for me. LGTM 
cl-2 with patched image |
barnabasbusa
approved these changes
May 8, 2025
|
Some required checks have failed. Could you please take a look @pawanjay176? 🙏 |
|
Some required checks have failed. Could you please take a look @pawanjay176? 🙏 |
pawanjay176
added
ready-for-merge
mergify
bot
added
the
waiting-on-author
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Resolves #7414
Proposed Changes
The health endpoint returns a 503 if the engine state is offline. The default state for the engine is
Offline. So until the first request to the EL is made and the state is updated, the health endpoint will keep returning 503s.This PR changes the default state to Online to avoid that. I don't think this causes any issues because in case the EL is actually offline, the first fcu will set the state to offline.
Pending testing on kurtosis.