Enable debug symbols by default in release builds #7418
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Binary size increased to 1.9GB, so uh, yeah we probably shouldn't change the default release profile. Maybe a new profile called... |
There was a problem hiding this comment.
Pull Request Overview
This PR enables debug symbols by default in release builds to improve backtraces in debugging scenarios without affecting the optimized maxperf releases.
- Enabled debug symbols in the release profile
- Explicitly disabled debug symbols in the maxperf profile while inheriting other settings from release
Comments suppressed due to low confidence (1)
Cargo.toml:302
- [nitpick] Consider moving the inherits field to the top of the [profile.maxperf] section to improve clarity on which settings are being inherited and overridden.
inherits = "release"
|
Not viable right now. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Turn on debug symbols for release builds so that we get more informative backtraces.
This won't affect releases, which use maxperf. If users building from source want to remove debug symbols they can opt in to maxperf, although I suspect nobody will notice any detriment from this change.