Skip to content

Move notifier and latency service to validator_services #7427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2025

Conversation

dknopik
Copy link
Member

@dknopik dknopik commented May 8, 2025

Proposed Changes

We would like to reuse the notifier and latency_service in Anchor. To make this possible, this PR moves these from validator_client to validator_services and makes them use the new ValidatorStore trait is used so that the code can be reused in Anchor.

macladson added a commit that referenced this pull request May 13, 2025
@michaelsproul michaelsproul added val-client Relates to the validator client binary ready-for-review The code is ready for review labels May 19, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels May 21, 2025
mergify bot added a commit that referenced this pull request May 21, 2025
@mergify mergify bot merged commit e29b607 into sigp:unstable May 21, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. val-client Relates to the validator client binary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants