Verifier: Use correct Timestamp hash algorithm #1385
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jku
force-pushed
the
use-correct-hash-algo
branch
from
52f38a3 to
6305fb1
Compare
jku
changed the title
Don't assume sha256. Use verify_message() from new rfc3161-client instead: it looks up the correct hash from the timestamp response. Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
use-correct-hash-algo
branch
from
6305fb1 to
0da31a1
Compare
jku
changed the title
|
lol, I made another seemingly unrelated fix in the new rfc3161-client and now lint fails because of the combination of these two fixes... trailofbits/rfc3161-client#152 This is just a lint issue so I silenced it for now but we can also wait for next rfc3161-client release. |
Signed-off-by: Jussi Kukkonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't assume sha256. Use verify_message() instead: it looks up the correct hash from the the timestamp response.