Skip to content

Add CI to test install-ability of requirements.txt file #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 5, 2023
Merged

Add CI to test install-ability of requirements.txt file #521

merged 3 commits into from
Mar 5, 2023

Conversation

di
Copy link
Member

@di di commented Mar 5, 2023 •
edited
Loading

This ensures the requirements.txt file can be installed on all Python versions without issue.

Fixes #520.

@di di force-pushed the test-requirements branch from 605208e to 0fa3de2 Compare March 5, 2023 14:14
@di
Copy link
Member Author

di commented Mar 5, 2023

Needs #522 first.

@di di mentioned this pull request Mar 5, 2023
Closed
@woodruffw woodruffw enabled auto-merge (squash) March 5, 2023 14:42
woodruffw
woodruffw approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@woodruffw woodruffw merged commit fc6e7d1 into main Mar 5, 2023
@woodruffw woodruffw deleted the test-requirements branch March 5, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.10: pip install -r requirements.txt fails due to unpinned importlib_resources
2 participants
@di @woodruffw