-
Notifications
You must be signed in to change notification settings - Fork 56
workflows: debug staging-tests #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: William Woodruff <[email protected]>
Well, that's interesting:
This is also failing in the ordinary CI but wasn't failing when this was merged, so it's possible that GitHub's own OIDC IdP is regressing here. |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Never mind, this was another case of "we didn't run the full CI suite because of ambient OIDC credential restrictions." Looks like we just need to be a little looser with our |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
I've added a 5 second leeway window on the validity period claims. This shouldn't be strictly necessary but the observed behavior points to a consistent clock skew between GitHub's own IdP and the Actions runners environment. Adding this leeway doesn't change the security boundary: the token still isn't verified in any sense, since Fulcio is responsible for verifying it. |
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
WIP.Closes #668.