Skip to content

workflows: debug staging-tests #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 6, 2023
Merged

workflows: debug staging-tests #669

merged 9 commits into from
Jun 6, 2023

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jun 6, 2023

WIP.

Closes #668.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw self-assigned this Jun 6, 2023
@woodruffw
Copy link
Member Author

Well, that's interesting:

  File "/home/runner/work/sigstore-python/sigstore-python/staging-env/lib/python3.11/site-packages/jwt/api_jwt.py", line 162, in decode_complete
    self._validate_claims(
  File "/home/runner/work/sigstore-python/sigstore-python/staging-env/lib/python3.11/site-packages/jwt/api_jwt.py", line 242, in _validate_claims
    self._validate_iat(payload, now, leeway)
  File "/home/runner/work/sigstore-python/sigstore-python/staging-env/lib/python3.11/site-packages/jwt/api_jwt.py", line 276, in _validate_iat
    raise ImmatureSignatureError("The token is not yet valid (iat)")
jwt.exceptions.ImmatureSignatureError: The token is not yet valid (iat)

This is also failing in the ordinary CI but wasn't failing when this was merged, so it's possible that GitHub's own OIDC IdP is regressing here.

woodruffw added 3 commits June 6, 2023 12:31
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Member Author

This is also failing in the ordinary CI but wasn't failing when this was merged, so it's possible that GitHub's own OIDC IdP is regressing here.

Never mind, this was another case of "we didn't run the full CI suite because of ambient OIDC credential restrictions." Looks like we just need to be a little looser with our iat flutter.

woodruffw added 2 commits June 6, 2023 12:59
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
Copy link
Member Author

I've added a 5 second leeway window on the validity period claims. This shouldn't be strictly necessary but the observed behavior points to a consistent clock skew between GitHub's own IdP and the Actions runners environment.

Adding this leeway doesn't change the security boundary: the token still isn't verified in any sense, since Fulcio is responsible for verifying it.

woodruffw added 2 commits June 6, 2023 13:08
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw marked this pull request as ready for review June 6, 2023 17:10
@woodruffw woodruffw requested a review from di June 6, 2023 17:10
@woodruffw woodruffw added component:signing Core signing functionality component:api Public APIs component:tests Unit and integration tests labels Jun 6, 2023
@woodruffw woodruffw merged commit 554483d into main Jun 6, 2023
@woodruffw woodruffw deleted the ww/debug-staging branch June 6, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:api Public APIs component:signing Core signing functionality component:tests Unit and integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Integration failure: staging instance
2 participants