sigstore: prep verify APIs for DSSE #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
woodruffw
added
component:verification
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Feb 15, 2024
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
jku
approved these changes
Feb 29, 2024
| (_, a_materials) = signing_materials("a.txt") | ||
| (file, offline_rekor_materials) = signing_bundle("bundle.txt") | ||
|
|
||
| with file.open(mode="rb", buffering=0) as input_: |
There was a problem hiding this comment.
I wonder if signing_materials() should just open the file and yield (input_, materials) instead so we can avoid doing this in the tests?
- Not every test needs input_ of course... but I would think
open()is not expensive in context. - some tests want to read the file twice so would then probably need
input_.seek(0)
There was a problem hiding this comment.
That works, although to go one step further: I think signing_materials/signing_bundle should probably just return bytes/Hashed directly, since the plan is to have both sign and verify take those types rather than do their own I/O 🙂
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.This is the first step towards DSSE verification support, breaking apart some of our internal design mistakes around the state carried in
VerificationMaterials. Merging this will allow us to be more flexible about the inputs passed toverify(), including DSSE statements and prehashed inputs asHashedobjects.