Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recovery email parameter to MFA creation #82

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+37 −4
Open

Add recovery email parameter to MFA creation #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3e38ab
update api to add recovery_email parameter
ethancanne Apr 3, 2025
3695d05
Create new test case for when recovery type is used
ethancanne Apr 3, 2025
b93f5e1
pr suggestions
ethancanne Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions features/request/RequestContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,22 +474,13 @@ public function iHaveProvidedAnRporiginOf($rpOrigin)
*/
public function iCallMfaCreate()
{
if (empty($this->requestData['recovery_email'])) {
$this->getIdBrokerClient()->mfaCreate(
$this->requestData['employee_id'],
$this->requestData['type'],
$this->requestData['label'],
$this->rpOrigin,
);
} else {
$this->getIdBrokerClient()->mfaCreate(
$this->requestData['employee_id'],
$this->requestData['type'],
$this->requestData['label'],
$this->rpOrigin,
$this->requestData['recovery_email'],
);
}
$this->getIdBrokerClient()->mfaCreate(
$this->requestData['employee_id'],
$this->requestData['type'],
$this->requestData['label'],
$this->rpOrigin,
$this->requestData['recovery_email'] ?? '',
);
}

/**
Expand Down
3 changes: 2 additions & 1 deletion features/request/request.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,8 @@ Feature: Formatting requests for sending to the ID Broker API
{
"employee_id": "12345",
"type": "webauthn",
"label": "Blue security key"
"label": "Blue security key",
"recovery_email": ""
}
"""

Expand Down
29 changes: 10 additions & 19 deletions src/IdBrokerClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,26 +316,17 @@ public function listUsers(array $fields = null, ?array $search = []): array
* @return array|null
* @throws ServiceException
*/
public function mfaCreate(string $employee_id, string $type, string $label = null, string $rpOrigin = '', ?string $recovery_email = null): ?array
public function mfaCreate(string $employee_id, string $type, string $label = null, string $rpOrigin = '', string $recovery_email = ''): ?array
{
if ($recovery_email === null) {
$result = $this->mfaCreateInternal([
'employee_id' => $employee_id,
'type' => $type,
'label' => $label,
'rpOrigin' => $rpOrigin,
]);
}
else{
$result = $this->mfaCreateInternal([
'employee_id' => $employee_id,
'type' => $type,
'label' => $label,
'rpOrigin' => $rpOrigin,
'recovery_email' => $recovery_email,
]);
}

var_dump($recovery_email);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a var_dump got left behind.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm glad you noticed that, I'll make sure to remove that

$result = $this->mfaCreateInternal([
'employee_id' => $employee_id,
'type' => $type,
'label' => $label,
'rpOrigin' => $rpOrigin,
'recovery_email'=> $recovery_email
]);

$statusCode = (int)$result[ 'statusCode' ];

if ($statusCode === 200) {
Expand Down