Skip to content

[FEATURE] Add library.json to set libArchive? #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timohueser opened this issue Dec 16, 2023 · 2 comments
Closed

[FEATURE] Add library.json to set libArchive? #357

timohueser opened this issue Dec 16, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@timohueser
Copy link

Hi,

When using simpleFOC with PlatformIO one currently has to set lib_archive = false in the platformio.ini file. This is a little bug-prone, as forgetting that line leads to some hard to troubleshoot failure modes (On my RP2040 it made it impossible to change the PWM frequency, with everything else working as expected).

In my opinion a less bug-prone way of dealing with this would be to add the following library.json file in the root of the project:

{
  "build": {
    "libArchive": false
  }
}

As far as I can tell this has the same effect and can't be forgotten by the user :)

@timohueser timohueser added the enhancement New feature or request label Dec 16, 2023
@runger1101001 runger1101001 self-assigned this Dec 17, 2023
@runger1101001
Copy link
Member

Wow, thank you for this hint! Is this a platformIO specific file or will this then also affect ArduinoIDE?

@runger1101001
Copy link
Member

Thanks for this, it looks like a PlatformIO specific file, so this looks kind of perfect for us. I will add it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants