Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule text-encoding-identifier-case: Change utf8 canonical to utf-8 #2600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rule text-encoding-identifier-case: Change utf8 canonical to utf-8 #2600

wants to merge 1 commit into from
+464 −123

Conversation

carlosjeurissen
Copy link

@carlosjeurissen carlosjeurissen commented Mar 19, 2025 •
edited by sindresorhus
Loading

Fixes #1926
Fixes #2547

@github-actions github-actions bot changed the title rule text-encoding-identifier-case: Change utf8 canonical to utf-8 Rule text-encoding-identifier-case: Change utf8 canonical to utf-8 Mar 19, 2025
@carlosjeurissen carlosjeurissen mentioned this pull request Mar 19, 2025
Open
@fisker
Copy link
Collaborator

fisker commented Mar 19, 2025

Please add an option to allow both.

@sindresorhus
Copy link
Owner

sindresorhus commented Mar 19, 2025 •
edited
Loading

The convention in Node.js (and as used in most Node.js docs) is utf8, and I don't see any reason to break that. I'm not against adding an option to support utf-8, but the default should continue to be utf8 (in our docs and code too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@carlosjeurissen @fisker @sindresorhus