Replace read-package-up with find-up-simple
#2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per the issue:
|
|
Ah I only saw the |
beeequeue
changed the title
read-package-up with empathicread-package-up with find-up-simple
|
The last test is failing on main as well. |
sindresorhus
approved these changes
Apr 2, 2025
fisker
reviewed
Apr 7, 2025
fisker
reviewed
Apr 7, 2025
fisker
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2151
I decided to uselukeed/empathicoverfind-updue to it being smaller, simpler, and dependency free.Changed to
find-up-simpleas I missed the comment mentioning it.I also extracted the similar logic into a shared utility (I wasn't sure whether to put it in
shared/orutils/) and added some simple caching for it.