Use emoji regex to compute emoji width #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmail
commented
Mar 25, 2025
index.js
Outdated
| const emojiMatch = character.match(emojiRegex()); | ||
| if (emojiMatch) { | ||
| const emoji = emojiMatch[0]; | ||
| const codePoints = [...emoji].length; |
There was a problem hiding this comment.
I got the idea about [...emoji].length from
Maybe there is a better/more performant approach but that looks good to me.
|
Length is not the same as width. |
|
😫, any guidance to get the width from the emoji? |
|
Maybe I could recall stringwidth on the segment when the emoji regexp matches? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
Fixes #56.