Introduce an internal version of replaceChildren #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaceChildren()
is used byaddProps()
andbetweenChildren()
internally. This PR introducesreplaceChildrenInternal()
that all 3 can use instead.replaceChildrenInternal()
doesn't have the dev warnings for the arguments. This avoids duplicate warnings whenaddProps()
orbetweenChildren()
call it, or when it calls itself recursively. This does potentially remove an argument check on the children for recursive calls, but that really isn't an edge case those checks were intended to catch. The warnings in that unlikely scenario would have been confusing anyway.replaceChildrenInternal()
also doesn't specify a default for theoptions
argument. This potentially allowsSKIP_COMMENTS
to be tree-shaken ifreplaceChildren()
isn't used directly.