Fix the types for isComment and isText #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types for
isComment
andisText
were usingComment
andText
incorrectly.Both
Comment
andText
were being imported fromvue
, but they weren't actually being used for the types of those two functions. Those values are both symbols, not types, so they were ignored in the type annotation. Instead, the globalComment
andText
types, used for DOM nodes, were being used.The simplest fix was to use
typeof Comment
andtypeof Text
, but to avoid future clashes I've renamed all the imported symbols to have less problematic names.The docs have been updated accordingly, though they still use the original names for the symbols.