Skip to content

Add Profile Submission in Profile Page #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2022
Merged

Add Profile Submission in Profile Page #290

merged 2 commits into from
Feb 1, 2022

Conversation

st42597
Copy link
Member

@st42597 st42597 commented Jan 28, 2022

스크린샷 2022-01-28 오후 9 29 58

problemList코드를 Submission형식에 맞춰 작성했습니다.
필터 기능은 api가 완성된 후에 개발할 예정입니다.

@st42597 st42597 added the FE Frontend tasks label Jan 28, 2022
@jimin9038 jimin9038 changed the base branch from master to dev/user-profile January 28, 2022 12:48
jimin9038
jimin9038 requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@jimin9038 jimin9038 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem list과 테이블 필드만 다른 정도라 크게 문제될 것은 없는 것 같아요😺
다만 filter 등은 API 구현 후 하되, class, data 이름 등은 먼저 이 PR에서 바꿔놓는 것이 좋을 것 같습니다.

@st42597 st42597 requested a review from jimin9038 February 1, 2022 16:01
jimin9038
jimin9038 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@jimin9038 jimin9038 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@st42597 st42597 merged commit 62983c3 into dev/user-profile Feb 1, 2022
@st42597 st42597 deleted the user/profile-submission branch February 1, 2022 16:33
jimin9038 pushed a commit that referenced this pull request Mar 2, 2022
@st42597 @jimin9038
Add Profile Submission in Profile Page (#290)
d48b8e6 
* add: profile submission page

* fix: minor fixes
jimin9038 pushed a commit that referenced this pull request Apr 1, 2022
@st42597 @jimin9038
Add Profile Submission in Profile Page (#290)
6150367 
* add: profile submission page

* fix: minor fixes
jimin9038 pushed a commit that referenced this pull request Apr 12, 2022
@st42597 @jimin9038
Add Profile Submission in Profile Page (#290)
487affd 
* add: profile submission page

* fix: minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimin9038 jimin9038 jimin9038 approved these changes

@pinecone28 pinecone28 Awaiting requested review from pinecone28

Assignees

@st42597 st42597

Labels
FE Frontend tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st42597 @jimin9038