[MNT] Temporary fix for lint errors to conform to the recent changes in linting rules see #1749 #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
fnhirwa
added
work in progress
fnhirwa
changed the title
fnhirwa
changed the title
fnhirwa
requested review from
benHeid,
fkiraly,
geetu040,
jdb78,
pranavvp16,
XinyuWuu and
yarnabrina
as code owners
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the linting errors after the lint rules were updated recently.
Initially added a lot of
noqato have a baseline that passes the lint check going to work on removing allnoqato the minimal value. This is still a work in progress.This temporary fix is for allowing PRs to be in mergeable states given that they pass code quality checks.
The exhaustive refactoring is being done in #1749 to ensure the code quality.