-
Notifications
You must be signed in to change notification settings - Fork 683
[ENH] Allow multiple instances from multiple mock classes in _safe_import
#1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1818 +/- ##
=======================================
Coverage ? 86.20%
=======================================
Files ? 47
Lines ? 5357
Branches ? 0
=======================================
Hits ? 4618
Misses ? 739
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pinging @jgyasu |
Hi @fnhirwa there have been some recent fixes concerning |
I suppose these have been merged? |
Yes, apologies! I do have some discussion to do around the tests but I am busy with my examinations right now so I think this can be merged and we can have a new PR later on if needed. |
I updated to what I believe is in sync now with |
…mport` (sktime#1818) The issue was spotted in sktime via sktime/sktime#8061 Updated the implementation and copied the unit tests to ensure that it works with pytorch-forecasting. closes sktime#1815
The issue was spotted in sktime via sktime/sktime#8061
Updated the implementation and copied the unit tests to ensure that it works with pytorch-forecasting.
closes #1815