[ENH] EXPERIMENTAL PR: make the data_module dataclass-like

[phoeenniixx]

This PR makes the data_modulel dataclass-like
See discussion in #1829

[phoeenniixx]

Hi @fkiraly, I tried to change the tests, is this what is intended? or should I need to make some more changes?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@fc8599c). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1832   +/-   ##
=======================================
  Coverage        ?   86.77%           
=======================================
  Files           ?       51           
  Lines           ?     5663           
  Branches        ?        0           
=======================================
  Hits            ?     4914           
  Misses          ?      749           
  Partials        ?        0           

Flag	Coverage Δ
cpu	86.77% <ø> (?)
pytest	86.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fkiraly]

Hi @fkiraly, I tried to change the tests, is this what is intended? or should I need to make some more changes?

Yes, this may be sufficient - but are you sure we do not use the attributes in #1812?

[phoeenniixx]

Hi @fkiraly, I tried to change the tests, is this what is intended? or should I need to make some more changes?

Yes, this may be sufficient - but are you sure we do not use the attributes in #1812?

we can merge this branch to #1812, then i think this should work?, just few adaptations may be required and most importantly the attributes are used with the help of metadata and __getitem__ there, which use the private variables only, so ig this is safe

And we are mainly using max_encoder_length and max_prediction_length which are not changed here

[phoeenniixx]

So should we merge this @fkiraly ?

[fkiraly]

So should we merge this @fkiraly ?

If this should be merged, you should turn it to a "ready for review" pull request, it is still a draft

[phoeenniixx]

yes, sorry didn't notice it was draft, i have made the final changes, please review