Passing root to isScrollbarClick #9
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for the recent release and for making this repo - it’s been incredibly useful.
I hope you don't mind the PR but I noticed that clicking and dragging the scrollbar still causes the active link state to stop updating correctly in some cases. I’ve created a small update to address this problem and hope it’s helpful.
Reproduction of issue being solved:
Solution:
isScrollbarClick
method to acceptroot
as a parameter and update the condition for identifying scrollbar clicks.isTop
andisBottom
checks withinisScrollbarClicked
Once again, I hope you don’t mind me opening this PR, and I really appreciate all the work you’ve done in making this project public.