Skip to content

chore: enforce singular config object for resolver stack #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Mar 24, 2025

This PR represents a component of step (1) in the following process:

  1. all config resolvers in Smithy and AWS SDKs will mutate a single config object (except the initial operation to generate the runtimeConfig)
  2. AWS SDK enforces the change from (1) with integration tests
  3. config resolvers and middleware functions are safe to refer to the config object, knowing it is a singleton and not a dangling reference to an intermediate object.

@kuhe kuhe merged commit e917e61 into smithy-lang:main Mar 24, 2025
10 checks passed
@kuhe kuhe deleted the fix/object-ownership-js branch March 24, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants