Skip to content

Support additional plugin function parameters #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2021

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented May 13, 2021

Issue #, if available:
Refs: aws/aws-sdk-js-v3#2211
Similar to: #302

Description of changes:
Currently the generated command calls additional runtime plugins, but
it only takes 1 parameter. To support endpoint discovery, we have to
pass more parameters which are specific to commands as follows:

    this.middlewareStack.use(
      getEndpointDiscoveryOptionalPlugin(configuration, {
        clientStack,
        options,
      })
    );

In the above example, the clientStack and options passed to the plugin
are used for calling endpoint discovery command.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title Updates to enable Endpoint Discovery Support additional plugin functional parameters May 13, 2021
@AllanZhengYP AllanZhengYP requested a review from kstich May 13, 2021 18:42
@AllanZhengYP
Copy link
Contributor

cc @kstich for a look

@trivikr trivikr changed the title Support additional plugin functional parameters Support additional plugin function parameters May 14, 2021
@trivikr trivikr merged commit e9ba41e into smithy-lang:main May 14, 2021
@trivikr trivikr deleted the client-endpoint-discovery branch May 14, 2021 17:52
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants