fix: update tsconfigs and package.json #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
suggested changes
Dec 17, 2019
| "remove-documentation": "rimraf ./docs", | ||
| "remove-js": "rimraf *.js && rimraf ./commands/*.js && rimraf ./shared/*.js && rimraf ./types/*.js", | ||
| "remove-maps": "rimraf *.js.map && rimraf ./commands/*.js.map && rimraf ./shared/*.js.map && rimraf ./types/*.js.map", | ||
| "remove-js": "rimraf *.js && rimraf ./commands/*.js && rimraf ./lib/*.js && rimraf ./models/*.js && rimraf ./protocols/*.js", |
There was a problem hiding this comment.
./lib was removed in #51. those get pulled in from @aws-sdk/smithy-client
| "remove-js": "rimraf *.js && rimraf ./commands/*.js && rimraf ./shared/*.js && rimraf ./types/*.js", | ||
| "remove-maps": "rimraf *.js.map && rimraf ./commands/*.js.map && rimraf ./shared/*.js.map && rimraf ./types/*.js.map", | ||
| "remove-js": "rimraf *.js && rimraf ./commands/*.js && rimraf ./lib/*.js && rimraf ./models/*.js && rimraf ./protocols/*.js", | ||
| "remove-maps": "rimraf *.js.map && rimraf ./commands/*.js.map && rimraf ./lib/*.js.map && rimraf ./models/*.js.map && rimraf ./protocols/*.js.map", |
There was a problem hiding this comment.
same as above. ./lib was removed.
srchase
approved these changes
Dec 17, 2019
srchase
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Add a region provider abstraction * Add node region providers * Add a generic provider package * Add a node default region provider * Refactor credential providers to use generic provider package
srchase
pushed a commit
that referenced
this pull request
Jun 16, 2023
* Add a region provider abstraction * Add node region providers * Add a generic provider package * Add a node default region provider * Refactor credential providers to use generic provider package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the tsconfig and npm scripts:
tsconfig.test.jsonis removed, all the tests are compiled usingtsconfig.json, the same config to releasingprepublishOnlytrait to callyarn build, this way we will build both browser distrubution and Node distributiontypes/anddist/, artifacts are no longer generated in place. Soremove-XXandclean-XXscripts are updated accordinglybrowserkey that informs bundler to use browser specific dependencies when bundling for browsersmoduleskey to provide a ESModule enter pointsideEffectskey makes webpack generate smaller bundles in ESModuleRelated to aws/aws-sdk-js-v3#555
/cc @srchase @trivikr
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.