Skip to content

Add default metadata type to FallibleTask #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2022
Merged

Add default metadata type to FallibleTask #39

merged 2 commits into from
Nov 26, 2022

Conversation

taiki-e
Copy link
Collaborator

@taiki-e taiki-e commented Nov 26, 2022

Prevents #33 from being a breaking change, e.g., in the following case.

type FT<T> = async_task::FallibleTask<T>;

@taiki-e taiki-e requested a review from notgull November 26, 2022 08:59
notgull
notgull approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@taiki-e taiki-e merged commit e249342 into master Nov 26, 2022
@taiki-e taiki-e deleted the taiki-e/default branch November 26, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @notgull