Skip to content

Client behind proxy without websocket support upgrades to websocket #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svestka opened this issue Sep 26, 2013 · 4 comments
Closed

Client behind proxy without websocket support upgrades to websocket #202

svestka opened this issue Sep 26, 2013 · 4 comments

Comments

@svestka
Copy link

svestka commented Sep 26, 2013

If a client is behind proxy without websocket support, it upgrades connection from polling to websockets anyway, which leads to unexpected hangs.

How to reproduce with nginx for example:
Just create simple proxy without websockets support and point engine.io-client to port 80 (or whatever port your nginx server listen to)

location /engine.io/ {
    proxy_set_header   X-Real-IP         $remote_addr;
    proxy_set_header   X-Forwarded-For   $proxy_add_x_forwarded_for;
    proxy_set_header   X-Forwarded-Proto $scheme;
    proxy_set_header   Host              $http_host;
    proxy_set_header   X-NginX-Proxy     true;
    proxy_set_header   Connection "";
    proxy_read_timeout 86400;
    proxy_http_version 1.1;
    proxy_pass http://localhost:3000/engine.io/;
}
@rauchg
Copy link
Contributor

rauchg commented Jan 17, 2014

@aeosynth do you think this is the same issue as socketio/engine.io#177 ?

@plievone
Copy link
Contributor

Fixed by socketio/engine.io#222 ?

@svestka
Copy link
Author

svestka commented Apr 19, 2014

I'm not able to reproduce the problem anymore, seems fixed.

I will keep an eye on it

@rauchg
Copy link
Contributor

rauchg commented Apr 19, 2014

We definitely tested this. Closing. Thanks @peterslivka

@rauchg rauchg closed this as completed Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants