require same transports unless upgrading

[aeosynth]

fixes socketio/engine.io-client#168

[aeosynth]

@guille ping? i've been using this in production, and have stopped receiving complaints about connection errors

[rauchg]

I think we need more comments in the code to explain the rationale. We also need to document the new parameter in verify

[rauchg]

This absolutely needs tests as well to avoid regressions

[deoxxa]

Any action on this? I've just found that the same thing happens on a particular wireless operator in Australia, owing to their use of a transparent proxy implemented with squid. If there are no current plans to write tests and get this merged, I'd be willing to wade around in whatever the testing bits are here and figure it out, but it would probably take me a lot longer than it'd take someone who's already familiar with engine.io internals.

[aeosynth]

Go for it.
On Jul 8, 2013 7:48 PM, "Conrad Pankoff" [email protected] wrote:

Any action on this? I've just found that the same thing happens on a
particular wireless operator in Australia, owing to their use of a
transparent proxy implemented with squid. If there are no current plans to
write tests and get this merged, I'd be willing to wade around in whatever
the testing bits are here and figure it out, but it would probably take me
a lot longer than it'd take someone who's already familiar with engine.iointernals.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/177#issuecomment-20650313
.

[kapouer]

Please comment this test: https://gist.github.com/kapouer/7634923

[rauchg]

Thanks a lot @kapouer you the man

[defunctzombie]

Is this PR still relevant?

[rauchg]

Very much so. Upgrading breaks polling on Squid and others.

[rauchg]

Because the websocket request gets passed as a regular request which then makes the socket error. It should be ignored instead. The carnegie guys are working on this one.