Ensure globals are functions before running instanceof checks
#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st them. `File` and `Blob` don't exist in Node, and `Buffer` and `ArrayBuffer` don't exist in HTML5. So if an app uses those globals for some other purpose and also uses `has-binary`, it can crash with a "TypeError: Expecting a function in instanceof check, but got <whatever>" error. This commit fixes that issue.
|
Thanks! |
darrachequesne
added a commit
to darrachequesne/socket.io-parser
that referenced
this pull request
Apr 24, 2017
darrachequesne
added a commit
to socketio/socket.io-parser
that referenced
this pull request
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileandBlobdon't exist in Node, andBufferandArrayBufferdon't exist in HTML5. So if an app uses those globals for some other purpose and also useshas-binary, it can crash with a "TypeError: Expecting a function in instanceof check, but got " error. This commit fixes that issue.refs socketio/socket.io#2871