TypeScript issues

[philkunz]

[email protected]/node_modules/socket.io-parser/build/cjs/index.d.ts (1,25): The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@socket.io/component-emitter")' call instead.

[darrachequesne]

Hi! I wasn't able to reproduce, could you please provide your tsconfig.json config file?

[philkunz]

@darrachequesne Sure:

{
"compilerOptions": {
"experimentalDecorators": true,
"useDefineForClassFields": false,
"target": "ES2022",
"module": "NodeNext",
"moduleResolution": "NodeNext",
"esModuleInterop": true,
"verbatimModuleSyntax": true
}
}

[plvo]

hey, same error for me:

node_modules/.pnpm/[email protected]/node_modules/socket.io-parser/build/cjs/index.d.ts:1:25 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("@socket.io/component-emitter")' call instead.

1 import { Emitter } from "@socket.io/component-emitter";
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in node_modules/.pnpm/[email protected]/node_modules/socket.io-parser/build/cjs/index.d.ts:1

my tsconfig.json:

{
    "compilerOptions": {
        "module": "NodeNext",
        "moduleResolution": "NodeNext",
        "target": "ES2020",
        "sourceMap": true,
        "outDir": "dist",
        "resolveJsonModule": true,
        "esModuleInterop": true,
        "allowArbitraryExtensions": true
    },
    "include": [
        "src/**/*"
    ],
}

I use pnpm and build with tsc:

{
  "name": "server",
  "version": "1.0.0",
  "main": "dist/index.js",
  "license": "MIT",
  "type": "module",
  "scripts": {
    "build": "tsc",
    "dev": "node dist/index.js",
    "start": "pnpm build && pnpm dev"
  },
  "dependencies": {
    "cors": "^2.8.5",
    "express": "^4.19.2",
    "socket.io": "^4.7.5"
  },
  "devDependencies": {
    "@types/node": "^20.12.7",
    "typescript": "^5.4.5"
  }
}

[TriangularCube]

Can confirm, also running into this problem.

Issue seems to be coming from the type declaration, and not the source file. So while TS is emitting to CJS, the declaration is getting picked up as importing from an ESM module.

[plvo]

Update: I used "skipLibCheck": true on my tsconfig.json

source: https://www.typescriptlang.org/tsconfig/#skipLibCheck

[philkunz]

@plvo ... You used the brute force method to make TypeScript shut up.

[plvo]

@philkunz yes it's not the best solution, I use it because it's a small project, but if there are other solutions, I'm interested

[darrachequesne]

@philkunz I was indeed able to reproduce the issue, thanks for providing your tsconfig.json file 👍

This should be fixed by socketio/emitter@e6aa1a3, included in @socket.io/[email protected].

Could you please check?

[philkunz]

@darrachequesne I comment on the the commit above, but the issue seems fixed for now.

[philkunz]

@darrachequesne Thank you!