Skip to content

Fix RedisStore #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Sep 19, 2011
Merged

Fix RedisStore #529

merged 37 commits into from
Sep 19, 2011

Conversation

dshaw
Copy link
Contributor

@dshaw dshaw commented Sep 19, 2011

Initialize Store on configuration.
Fix typo.
Fix RedisClients configuration.

dshaw and others added 30 commits July 10, 2011 17:11
@3rd-Eden
Copy link
Contributor

I'm a big fat major diddly doo +1 on this one. Because it has been requested so many times before. (oh and its nice to show this off during my nodejsconf.it preso ;$ )

like OMGF< WE SCALE ACROSS MULITPLE PROCESSES AUTOMAGICALLY FOR YOU

cc @guille <3? waddayathink

@dshaw
Copy link
Contributor Author

dshaw commented Sep 19, 2011

Runs great in production!

@tglines
Copy link

tglines commented Sep 19, 2011

+1 ... Just when I was about to abandon the store and hack up a custom solution, well done

@alindeman
Copy link

+1

@jamescarr
Copy link

+394,302

rauchg added a commit that referenced this pull request Sep 19, 2011
@rauchg rauchg merged commit 1468917 into socketio:master Sep 19, 2011
@alindeman
Copy link

OH SWEET. Nice work all.

darrachequesne pushed a commit that referenced this pull request Jul 8, 2024
Ensure all assignments for chunks are Buffer when they should, even when onData is supposed to not
be called again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants