Unable to create reserved-guest #1402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
requested changes
Dec 18, 2020
SoftLayer/managers/vs.py
Outdated
| @@ -465,7 +465,7 @@ def reload_instance(self, instance_id, | |||
| 'FORCE', config, id=instance_id) | |||
|
|
|||
| def _generate_create_dict( | |||
| self, cpus=None, memory=None, hourly=True, | |||
| self, cpus=None, memory=None, useHourlyPricing=True, | |||
There was a problem hiding this comment.
Don't change names of function arguments if we can help it. Change this back to "hourly" so we don't break anyone's code that happens to be using this function.
SoftLayer/managers/vs.py
Outdated
| @@ -504,7 +504,7 @@ def _generate_create_dict( | |||
| "hostname": hostname, | |||
| "domain": domain, | |||
| "localDiskFlag": local_disk, | |||
| "hourlyBillingFlag": hourly, | |||
| "useHourlyPricing": useHourlyPricing, | |||
There was a problem hiding this comment.
Make sure this change doesn't break hourly VSI orders of any kind. I'm guessing it likely won't, but we have been using hourlyBillingFlag forever, so its kinda weird it stopped working for reserved capacity instances.
|
I finally had a moment to get back to this, and I decided that instead of doing all the work needed to get reserved capacity to allow hourly creation... were just going to force monthly until someone asks us to do hourly as well. I'll fix this in #1454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1395