Skip to content

Add testing and support for python 3.9. #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

camporter
Copy link
Member

@camporter camporter commented Mar 2, 2021

Remove testtools as a test dependency. It's not used except for a
version skip that is easy to replace. testtools still relies on
unittest2, a python 2-ism that generates warnings in python 3.9.

Fix the snapcraft release by updating to a newer snapcraft action
that fixes the 'add-path' error.

Fixes #1392

Remove testtools as a test dependency. It's not used except for a
version skip that is easy to replace. testtools still relies on
unittest2, a python 2-ism that generates warnings in python 3.9.

Fix the snapcraft release by updating to a newer snapcraft action
that fixes the 'add-path' error.
@camporter camporter requested review from allmightyspiff and ATGE March 2, 2021 01:57
@allmightyspiff allmightyspiff added the Core Issues dealing with core functionality label Mar 2, 2021
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@allmightyspiff allmightyspiff merged commit ffdca18 into softlayer:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues dealing with core functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix snapcraft build
3 participants