Skip to content

Add preset datatype in slcli virtual detail #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2021
Merged

Add preset datatype in slcli virtual detail #1435

merged 3 commits into from
Mar 19, 2021

Conversation

caberos
Copy link
Contributor

@caberos caberos commented Mar 9, 2021

ATGE
ATGE suggested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

  • ❌ slcli vs detail 107879710

FernandoOjeda
FernandoOjeda approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@FernandoOjeda FernandoOjeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@allmightyspiff allmightyspiff linked an issue Mar 12, 2021 that may be closed by this pull request
Add preset datatype in slcli virtual detail #1434
Closed
allmightyspiff
allmightyspiff requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use utils.lookup to avoid keyErrors when adding in a preset.

ATGE
ATGE suggested changes Mar 15, 2021
View reviewed changes
ATGE
ATGE approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

  • ✔️ slcli vs detail 107879710
  • ✔️ slcli vs detail 112238162

@allmightyspiff allmightyspiff merged commit 197c675 into softlayer:master Mar 19, 2021
allmightyspiff
allmightyspiff reviewed Mar 19, 2021
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@allmightyspiff allmightyspiff mentioned this pull request Apr 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff requested changes

@ATGE ATGE ATGE approved these changes

@FernandoOjeda FernandoOjeda FernandoOjeda approved these changes

Assignees

@caberos caberos

Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add preset datatype in slcli virtual detail
4 participants
@caberos @allmightyspiff @ATGE @FernandoOjeda