IBMid Authentication support #1447

allmightyspiff · 2021-03-25T22:27:07Z

Allows for using an IBMid when using config setup.

Testing

slcli config setup --ibmid
Will let you login with the Username/Password that you can login to cloud.ibm.com with (unless you have an @ibm.com email, then use --sso)
slcli config setup --sso
Lets you login with your SSO Token, will prompt the user to open a webpage to get the token
slcli config setup --cloud_key
Uses a IBM Cloud API key to login
slcli config setup --classic_key
Old behavior, uses classic API keys. Can still use the old SL password as well.

The IBMid setups will still create an SL API key for the user at the end though.

…tion

… its own command

ATGE

Testing

✔️ $ slcli config setup --auth=cloud_key
✔️ $ slcli config setup --auth classic_key
❌ $ slcli config setup --auth sso

Endpoint (public|private|custom) [https://api.softlayer.com/rest/v3.1]: 
Get a one-time code from https://identity-1.us-south.iam.cloud.ibm.com/identity/passcode to proceed.

Open the URL in the default browser? [Y/n] [Y]: n
One-time code: code-test
An unexpected error has occured:
Traceback (most recent call last):
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/CLI/core.py", line 209, in main
    cli.main(**kwargs)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/CLI/config/setup.py", line 83, in cli
    username, api_key = sso_login(env)
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/CLI/config/setup.py", line 255, in sso_login
    client = SoftLayer.API.IAMClient(config_file=env.config_file)
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/API.py", line 178, in __init__
    timeout=self.settings['softlayer'].getint('timeout'),
  File "/usr/lib/python3.6/configparser.py", line 1283, in get
    fallback=fallback, **kwargs)
  File "/usr/lib/python3.6/configparser.py", line 819, in getint
    fallback=fallback, **kwargs)
  File "/usr/lib/python3.6/configparser.py", line 809, in _get_conv
    **kwargs)
  File "/usr/lib/python3.6/configparser.py", line 803, in _get
    return conv(self.get(section, option, **kwargs))
ValueError: invalid literal for int() with base 10: '30.0'

❌ $ slcli config setup --auth ibmid

Endpoint (public|private|custom) [https://api.softlayer.com/rest/v3.1]: 
Email: [email protected]
Password: 
An unexpected error has occured:
Traceback (most recent call last):
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/CLI/core.py", line 209, in main
    cli.main(**kwargs)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/decorators.py", line 64, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/home/.../lib/python3.6/site-packages/Click-7.0-py3.6.egg/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/CLI/config/setup.py", line 74, in cli
    username, api_key = ibmid_login(env)
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/CLI/config/setup.py", line 153, in ibmid_login
    client = SoftLayer.API.IAMClient(config_file=env.config_file)
  File "/home/.../lib/python3.6/site-packages/SoftLayer-5.9.3-py3.6.egg/SoftLayer/API.py", line 178, in __init__
    timeout=self.settings['softlayer'].getint('timeout'),
  File "/usr/lib/python3.6/configparser.py", line 1283, in get
    fallback=fallback, **kwargs)
  File "/usr/lib/python3.6/configparser.py", line 819, in getint
    fallback=fallback, **kwargs)
  File "/usr/lib/python3.6/configparser.py", line 809, in _get_conv
    **kwargs)
  File "/usr/lib/python3.6/configparser.py", line 803, in _get
    return conv(self.get(section, option, **kwargs))
ValueError: invalid literal for int() with base 10: '30.0'

As a workaround, changing the value in the file "~/.softlayer" from timeout = 30.0 to timeout = 30, then failed tests work as expected.

OS ubuntu 18

SoftLayer/CLI/config/setup.py

FernandoOjeda · 2021-03-29T15:51:10Z

If I use the following command to authenticate with wrong credentials, I got an error.

slcli config setup --auth ibmid

FernandoOjeda · 2021-03-29T16:15:28Z

If I enter a invalid One-time code data using slcli config setup --auth sso, I got the following error.

Co-authored-by: ATGE <[email protected]>

…on into issues1315

allmightyspiff · 2021-03-29T22:27:28Z

Fixed the issue with floating point timeouts, and better handling of IBMid Authentication.

FernandoOjeda

Looks good and It is working well.

caberos

LGTM.

allmightyspiff added 3 commits March 22, 2021 17:16

softlayer#1315 basic IAM authentication support, and slcli login func…

9f5abad

…tion

softlayer#1315 moved the IBMID login stuff to config setup instead of…

20630be

… its own command

Tox fixes

7ae7588

allmightyspiff added the CLI label Mar 25, 2021

allmightyspiff requested review from caberos, ATGE and FernandoOjeda March 25, 2021 22:27

allmightyspiff self-assigned this Mar 25, 2021

ATGE reviewed Mar 27, 2021

View reviewed changes

SoftLayer/CLI/config/setup.py Outdated Show resolved Hide resolved

allmightyspiff and others added 4 commits March 29, 2021 16:57

fixed code review comments, a few more unit tests

8aa6511

Added -a as an option

485d9f9

Co-authored-by: ATGE <[email protected]>

tox fixes

3e34733

Merge branch 'issues1315' of github.com:allmightyspiff/softlayer-pyth…

d730b0a

…on into issues1315

fixing a test

e20ceea

allmightyspiff linked an issue Apr 2, 2021 that may be closed by this pull request

ibmcloud authentication support #1315

Closed

FernandoOjeda approved these changes Apr 5, 2021

View reviewed changes

caberos approved these changes Apr 5, 2021

View reviewed changes

allmightyspiff merged commit 170418c into softlayer:master Apr 6, 2021

allmightyspiff deleted the issues1315 branch April 6, 2021 18:41

allmightyspiff mentioned this pull request Apr 27, 2021

v5.9.4 Release Notes and Version bump #1478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IBMid Authentication support #1447

IBMid Authentication support #1447

allmightyspiff commented Mar 25, 2021

ATGE left a comment

FernandoOjeda commented Mar 29, 2021

FernandoOjeda commented Mar 29, 2021 •

edited

Loading

allmightyspiff commented Mar 29, 2021

FernandoOjeda left a comment

caberos left a comment

IBMid Authentication support #1447

IBMid Authentication support #1447

Conversation

allmightyspiff commented Mar 25, 2021

Testing

ATGE left a comment

Choose a reason for hiding this comment

Testing

FernandoOjeda commented Mar 29, 2021

FernandoOjeda commented Mar 29, 2021 • edited Loading

allmightyspiff commented Mar 29, 2021

FernandoOjeda left a comment

Choose a reason for hiding this comment

caberos left a comment

Choose a reason for hiding this comment

FernandoOjeda commented Mar 29, 2021 •

edited

Loading