-
Notifications
You must be signed in to change notification settings - Fork 192
Show component versions on hw detail #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing
- ✔️ slcli hw detail --components 1866407
: components : :.....................:................:...........................:..................: :
: : : name : version : date : component-type : :
: : :.....................:................:...........................:..................: :
: : : X11DPU+_R1.10 : 3.3a 7-21-2020 : 2020-08-28T12:48:59-06:00 : MOTHERBOARD : :
: : : AOC-2UR66-i4XTF : 6.01(6.01) : 2021-02-16T11:46:32-06:00 : NETWORK_CARD : :
: : : 9461-16i : 5.130.00-3059 : 2020-05-22T10:44:07-06:00 : DRIVE_CONTROLLER : :
: : : AST2500 - Onboard : 3.10 : 2020-09-16T15:09:26-06:00 : REMOTE_MGMT_CARD : :
: : : AOM-TPM-9671H : 6.43.243.0 : 2020-01-24T15:28:41-06:00 : SECURITY_DEVICE : :
: : : Enterprise Capacity : TN04 TN04 : 2019-07-09T20:58:53-06:00 : HARD_DRIVE : :
: : : Enterprise Capacity : TN04 TN04 : 2019-07-09T20:58:53-06:00 : HARD_DRIVE : :
: : :.....................:................:...........................:..................: :
: tags : - :
:..................:.................................................................................................................:
below, some suggestions to improve the information about the components(maybe adding the id too)::
: components : :...............................................................................:..................:...........................:..................: :
: : : name : Firmware version : Firmware build date : Type : :
: : :...............................................................................:..................:...........................:..................: :
: : : SuperMicro / MBD-X11DPU / X11DPU+_R1.10 / Intel Xeon DualProc / 2 : 3.3a 7-21-2020 : 2020-08-28T12:48:59-06:00 : MOTHERBOARD : :
: : : SuperMicro / AOC-2UR66-I4XTF / AOC-2UR66-i4XTF / 1 / 4 : 6.01(6.01) : 2021-02-16T11:46:32-06:00 : NETWORK_CARD : :
: : : LSI / DRIVE CONTROLLER / 9461-16i / SATA/SAS - MegaRAID SAS 9461-16i SGL / 16 : 5.130.00-3059 : 2020-05-22T10:44:07-06:00 : DRIVE_CONTROLLER : :
: : : Aspeed / AST2500 - Onboard / IPMI - KVM / Remote Management Count1 : 3.10 : 2020-09-16T15:09:26-06:00 : REMOTE_MGMT_CARD : :
: : : SuperMicro / AOM-TPM-9671H-P / AOM-TPM-9671H / Infineon TPM Module / 1 : 6.43.243.0 : 2020-01-24T15:28:41-06:00 : SECURITY_DEVICE : :
: : : Seagate / ST1000NM0055 / Enterprise Capacity / ST1000NM0055 / 1000 : TN04 TN04 : 2019-07-09T20:58:53-06:00 : HARD_DRIVE : :
: : : Seagate / ST1000NM0055 / Enterprise Capacity / ST1000NM0055 / 1000 : TN04 TN04 : 2019-07-09T20:58:53-06:00 : HARD_DRIVE : :
: : :...............................................................................:..................:...........................:..................: :
: tags : - :
:..................:.....................................................................................................................................................:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I like @ATGE 's suggestions, once those are added this should be good to go.
Thanks.
SoftLayer/CLI/hardware/detail.py
Outdated
components_table.align['date'] = 'l' | ||
ids = [] | ||
for component in components: | ||
if component['id'] not in ids: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there duplicate ids
in the components list? I would assume this check wouldn't be needed. But if this check is preventing duplicate line entries or something feel free to keep it in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there are some unintended changes here. Please update this branch with the latest changes from master and I think those should go away, hopefully.
Once that is done this should be good to go. Thanks.
Thanks for merging in the changes from master, but it still looks like your accidently committing changes you didn't mean to. |
#1465